-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding audit --diff
functionality
#95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far, just more discussion stuff.
@@ -1 +1 @@ | |||
VERSION = '0.10.5' | |||
VERSION = '0.11.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B/c this will make it so that people need to manually update the baseline's, do you think we should add the autoupdate baselines
functionality now? I think so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was already merged? But yes, I agree with you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should update the changelog, but #90 was a bug fix for the update functionality, before running the temp bandaid fixer.
|
||
base64_secret = 'c2VjcmV0IG1lc3NhZ2Ugc28geW91J2xsIG5ldmVyIGd1ZXNzIG15IHBhc3N3b3Jk' | ||
hex_secret = '8b1118b376c313ed420e5133ba91307817ed52c2' | ||
basic_auth = 'http://username:whywouldyouusehttpforpasswords@example.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 except let's wait until we make the pre-commit
hook autoupdate the baseline
I guess we can merge this one now @domanchi 👍 (I'd like you to have the GitHub square on account of making the PR 😁 ) |
Testing
Output
Features
Hopefully this will better support plugin developers, to make the process easier to configure limits and plugin regexes!
Backwards Compatibility Considerations